Skip to content

Add issue delete notifier #34592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Jun 25, 2025
Merged

Add issue delete notifier #34592

merged 26 commits into from
Jun 25, 2025

Conversation

badhezi
Copy link
Contributor

@badhezi badhezi commented Jun 3, 2025 •
edited by lunny
Loading

Fixes #34591

A reference regarding the deletion of issue webhooks on GitHub: https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=deleted#issues

badhezi and others added 19 commits April 15, 2025 19:56
@badhezi
use the correct context data for PR link template in issue card
8d799c2
@badhezi
Merge branch 'main' into main
f2a2acf
@GiteaBot
Merge branch 'main' into main
5cc1bda
@GiteaBot
Merge branch 'main' into main
54d37d1
@badhezi
Merge branch 'go-gitea:main' into main
ac25150
@badhezi
Merge branch 'go-gitea:main' into main
e11a339
@badhezi
Merge branch 'go-gitea:main' into main
104eecc
@badhezi
Merge branch 'go-gitea:main' into main
bcc4ade
@badhezi
Merge branch 'go-gitea:main' into main
a7aaa79
@badhezi
Merge branch 'go-gitea:main' into main
b46d314
@badhezi
Merge branch 'go-gitea:main' into main
4e2434b
@badhezi
Merge branch 'go-gitea:main' into main
7f72fe9
@badhezi
Merge branch 'go-gitea:main' into main
c6acfc1
@badhezi
Merge branch 'go-gitea:main' into main
016c2f3
@badhezi
Merge branch 'go-gitea:main' into main
a3c2953
@badhezi
Merge branch 'go-gitea:main' into main
4d7ea0d
@badhezi
Merge branch 'go-gitea:main' into main
bfa2d10
@badhezi
Merge branch 'go-gitea:main' into main
0d50b75
@badhezi
add issue delete notifier
c511c71
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 3, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jun 3, 2025
@badhezi badhezi marked this pull request as ready for review June 3, 2025 07:10
lunny
lunny reviewed Jun 3, 2025
View reviewed changes
@lunny
Copy link
Member

lunny commented Jun 3, 2025 •
edited
Loading

A webhook integration test is necessary. Since there are many examples, it's not too difficult. You can add a test function at https://github.com/go-gitea/gitea/blob/main/tests/integration/repo_webhook_test.go
It's better to have a ref links to github's webhook docs in the pull request content.

@lunny lunny added this to the 1.25.0 milestone Jun 3, 2025
@lunny lunny added the type/enhancement An improvement of existing functionality label Jun 3, 2025
@badhezi
Copy link
Contributor Author

badhezi commented Jun 4, 2025

A webhook integration test is necessary. Since there are many examples, it's not too difficult. You can add a test function at https://github.com/go-gitea/gitea/blob/main/tests/integration/repo_webhook_test.go It's better to have a ref links to github's webhook docs in the pull request content.

I added tests for both issue and pull request delete.

It's better to have a ref links to github's webhook docs in the pull request content.

I didn't quite understand what you meant by that, can you explain?

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 4, 2025
@lunny
Copy link
Member

lunny commented Jun 4, 2025

A webhook integration test is necessary. Since there are many examples, it's not too difficult. You can add a test function at https://github.com/go-gitea/gitea/blob/main/tests/integration/repo_webhook_test.go It's better to have a ref links to github's webhook docs in the pull request content.

I added tests for both issue and pull request delete.

It's better to have a ref links to github's webhook docs in the pull request content.

I didn't quite understand what you meant by that, can you explain?

I updated the content and add a reference link to github's webhook documentation directly.

@lunny
Copy link
Member

lunny commented Jun 18, 2025

last call @go-gitea/technical-oversight-committee

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 25, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 25, 2025
@lunny lunny enabled auto-merge (squash) June 25, 2025 18:26
@lunny lunny merged commit c67a839 into go-gitea:main Jun 25, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 25, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 26, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
e0ab522 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Add issue delete notifier (go-gitea#34592)
  Refactor "change file" API (go-gitea#34855)
  Fix some log and UI problems (go-gitea#34863)
  Update go tool dependencies (go-gitea#34845)
  Fix archive API (go-gitea#34853)
  Update `uint8-to-base64`, remove type stub (go-gitea#34844)
  Refactor repo contents API and add "contents-ext" API (go-gitea#34822)
  [skip ci] Updated translations via Crowdin
  fix(issue): Replace stopwatch toggle with explicit start/stop actions (go-gitea#34818)
  Remove unused variable HUGO_VERSION (go-gitea#34840)
  Fix SSH LFS timeout (go-gitea#34838)
  Ignore force pushes for changed files in a PR review (go-gitea#34837)
  Fix log fmt (go-gitea#34810)
  Fix team permissions (go-gitea#34827)
  Fix job status aggregation logic (go-gitea#34823)
  [skip ci] Updated translations via Crowdin
  correct migration tab name (go-gitea#34826)
  Refactor template helper (go-gitea#34819)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/translation type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.

Deletion of issue does not trigger webhook
4 participants
@badhezi @lunny @wxiaoguang @GiteaBot